Does the Tornado adapter support AsyncApp? #754

Activity

1. seratch

   added

   questionFurther information is requestedFurther information is requested

   area:adapter

   on Nov 2, 2022
2. seratch commented on Nov 2, 2022

   

   seratch

   on Nov 2, 2022

   Contributor

   More actions

   Hi @castrapel, thanks for asking the question.

   Since tornado.web.RequestHandler does not support async functions for get/post etc., the built-in Tornado adapter does not support AsyncApp use cases. See also: https://www.tornadoweb.org/en/stable/web.html

   Checking the following resources may be helpful too. However, as far as I know, the async related decorator does not work with bolt-python in the way that you expect.

   • https://www.tornadoweb.org/en/stable/guide/async.html
   • https://stackoverflow.com/questions/49199638/tornado-web-asynchronous

   If you would like to make your listeners/middleware async for some reason, I'd suggest going with other modern asyncio-based frameworks such as AIOHTTP, FastAPI, Falcon, and Sanic. You can find examples here.

   If you have a certain reason to use Tornado over others, I highly recommend going with App and synchronous code. With that being said, if you are keen to explore some ways to adjust the adapter, you can fork it and try whatever may better work for you. Here is the adapter code: https://github.com/slackapi/bolt-python/tree/v1.15.2/slack_bolt/adapter/tornado As you can see, there are only two files and they are quite simple.

   I hope this was helpful to you.
3. castrapel commented on Nov 2, 2022

   

   castrapel

   on Nov 2, 2022

   Last edited by castrapel

   Author

   More actions

   Thank you for the response. tornado.web.RequestHandler does indeed support async def post, async def get, the stackoverflow is showing the Python2 way of handling Async. I am not sure why the Tornado team didn't document it well. Here is a benchmark comparison. Here is a way to test Tornado async.

   mkdir -p /tmp/tornadotest
   cd /tmp/tornadotest
   python3 -m venv env
   pip install tornado
   vim server.py # Paste in the contents of server.py below and save
   python server.py 
   # Visit http://localhost to confirm that you receive a text response: `GET request`

   Contents of server.py:

   import tornado.web
   import tornado.ioloop
   import tornado.options
   import tornado.httpserver
   
   import tornado.web
   
   class TestHandler(tornado.web.RequestHandler):
       async def get(self):
           self.write("GET request")
           
       async def post(self):
           self.write("POST request")
   
   routes = [
       (r"/", TestHandler),
   
   ]
   
   def make_app(debug: bool):
       return tornado.web.Application(routes, debug=debug)
   
   def run_service():
       debug_mode = True
       port = "8000"
       app = make_app(debug=debug_mode)
       app.listen(port)
       tornado.ioloop.IOLoop.current().start()
   
   if __name__ == "__main__":
       run_service()
4. seratch

   added

   enhancementNew feature or requestNew feature or request

   and removed

   questionFurther information is requestedFurther information is requested

   on Nov 2, 2022
5. seratch

   added this to the 1.15.3 milestone on Nov 2, 2022
6. seratch

   self-assigned this

   on Nov 2, 2022
7. seratch commented on Nov 2, 2022

   

   seratch

   on Nov 2, 2022

   Contributor

   More actions

   @castrapel Thanks for sharing this and I'm glad to hear that async functions are actually supported!

   I am taking day offs until Friday. I will look into the enhancement after coming back. If you are in a hurry, please consider copying the adapter code and editing it to work with async functions for now.
8. castrapel commented on Nov 3, 2022

   

   castrapel

   on Nov 3, 2022

   Author

   More actions

   Thanks @seratch, I'd appreciate your help here! Not in a big hurry on my end.
9. seratch

   closed this as completedin #758on Nov 8, 2022
10. seratch

    added a commit that references this issue on Nov 8, 2022

    Fix #754 by adding the async version of Tornado adapter (#758)

    This issue will close once commit cbf2383 is merged into the 'main' branch.

    cbf2383