Repository navigation
The next in middleware args overwrites Python built-in one #370
Description
Activity
- changed the title
[-][BUG] Middleware.process `next` argument overwrites Python built-in[/-][+]The `next` in middleware args overwrites Python built-in one[/+]on Jun 7, 2021 Hi @leblancfg, thanks for taking the time to report this!
Indeed, this is possibly an issue when you use the built-in
nextin a listener function. As removing thenextis a breaking change, we'll add an aliasnext_for it. The change will be included in the next minor version.Reacted by Niko Draca, Michael Brooks, François Leblanc and Jeremy SchulmanReally great suggestion @leblancfg, thanks for creating an issue for this! ❤️
- added a commit that references this issue
on Jul 9, 2021
slack_boltversionCurrent
HEAD.Description
The keyword
nextused inslack_bolt.middleware.middleware.process()overwrites the Python builtinnext(), used to produce the next item in iterables and generators. We are currently trying to pass a generator to a custom middleware, having us resorting in using a hack to use the generator as middleware.Please consider using another variable name, or
next_.Cheers, and thank you for your great work! ❤️
C.C. @nikodraca