Repository navigation
Enable developers to customize the way to handle unmatched requests #273
Description
Activity
This proposal sounds great to me, Kaz. I like that it uses the existing
@app.errorlistener.I have a lot of these filling up my logs also. Is there documentation that can just help me to understand what the root cause of this is?
@Shadrocks Your app does not have the listeners for incoming requests. I would recommend enabling debug-level logging (https://slack.dev/bolt-python/concepts#logging) and checking what types of payloads to your app. If you have questions regarding this topic, please file a new GitHub issue for the question (we are using this issue for a new feature development - it'd be appreciated if you could understand this).
I was going to modify the internals of bolt-python not to bring any breaking changes to the existing apps but I found that it's not feasible as a single bolt app can have only one
@app.errorlistener function.For this reason, I'd propose introducing a new flag to explicitly turn the new behavior on -
raise_error_for_unhandled_request. As I will submit the pull request, see the details in the PR changes.- changed the title
[-]Enable developers to customize the way to handle unmtached requests [/-][+]Enable developers to customize the way to handle unmatched requests [/+]on Apr 12, 2021 - added a commit that references this issue
on Apr 19, 2021
If an incoming request does not match with any listeners in a Bolt app, the Bolt app responds to the request with 404 response status. The following lines of code are relevant parts in
App/AsyncApp:There is no way to append custom logic for the patterns. A common use case can be to customize the logging in the scenario.
To improve this, I'm thinking to change the behavior as below:
BoltUnhandledRequestError(BoltError)here and enable@app.errorlistener to handle the patternApp/AsyncAppinternals. If a request is unhandled,App/AsncAppraisesBoltUnhandledRequestErrorand lets@app.errorlistener handle it. If@app.errorlistener does not return anyBoltResponseor set status to theresponseargument,App/AsncAppfalls back to the current logic, which outputs simple log message and returns 404 status anyway.If there is no concern about this change, we'll apply the change in the next minor version (1.5.0).
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.