How can I back out of install slack app? As you gave installation_store/authorize as well, token will be unused. #256

Activity

1. seratch

   added

   questionFurther information is requestedFurther information is requested

   on Mar 9, 2021
2. seratch commented on Mar 9, 2021

   

   seratch

   on Mar 9, 2021

   Contributor

   More actions

   Hi @Roblrobl, we're glad to know you like Bolt and you have been enjoying Slack app development!

   As you gave installation_store/authorize as well, token will be unused.

   This warning message indicates your App constructor got both installation_store and token arguments during its initialization. token here is specifically the token argument in the App constructor. The token could be passed either as the explicit argument or via env variables. I guess this is the latter pattern.

   a) Is there an easy way to back this out? I removed the extra configs on app settings. Didn't work. Do I need to completely uninstall the app?

   So, a quick answer is "You can run unset SLACK_BOT_TOKEN to suppress the warning!".

   App constructor uses token argument if exists. If the arg doesn't exist, the constructor tries to load SLACK_BOT_TOKEN env variable for it. I'm sure that your shell should have the env variable in the shell session. This warning is for better developer friendliness but I'm sorry for making you confused.

   c) Any other suggestions on how to segregate production vs. test apps when only used internally?

   I do understand this is crucial for better development productivity and also for making app management more secure and organized. At this point, the safest way is to create another Slack app for the tests and development. This is the approach you've already mentioned this way:

   One workaround could be to create the slack app all over again in a development slack workspace, then juggle the startup to handle different sets of configuration data.

   Although I cannot tell anything at this point, the Slack Platform team has been actively discussing better developer experience of Slack apps. The Slack team may be able to come up with some solution sometime in the future but, until then, please go with having multiple Slack apps.

   I hope this was helpful to you!
3. rob-laddish commented on Mar 9, 2021

   

   rob-laddish

   on Mar 9, 2021

   Last edited by rob-laddish

   Author

   More actions

   Hello again @seratch and thank you again for the quick response and good information. For dev/production, I will try to use multiple slack apps once I get this working again.

   One thing that puzzled me was that I didn't actively pass an installation_store to the App() constructor. I had only called app=App(token=xyz) and could see no such constructs in my app folder, and no environment variables for an install store. All I had done was look at the "add to slack" requests/response and basically did nothing with the data and then my app stopped working. It runs with the warning above, but doesn't get any events from slack.

   --> update, I found if both the SLACK_CLIENT_ID and SLACK_CLIENT_SECRET env vars are set, it looks like you're assuming an installation_store is used and setting it up? If I remove one of those env vars, the warning goes away. One suggestion: if you're assuming and creating installation_store objects for us (vs passing to constructor), change the warning message to reflect it. Perhaps something like: Warning: the env vars x & y were found, so we created an installation_store object for you, but that conflicts with token, so token was ignore. Please remove one of those vars if you want to use token.

   Finally a quick architecture question. If an app is added to multiple workspaces, does a single App() call to bolt register them all at once? And then a need to look at both team_id and user_id in the callbacks? Or instead does one startup a new process, one process per workspace? If it needs a process per workspace, how does this work ok with Apache/mod_wsgi in how it wants to setup # threads and processes in the apache config?

   Finally, if we ever did go to slack enterprise, and our bot EventBot was used by the same person across multiple workspaces, it would be nice if a user could login to our internal website and see a comprehensive view across all our enterprise workspaces. Is there a best practice around unique account keys for how I store the data and login to Flask? user_id? workspace_id + user_id? or perhaps just the users email to keep it common?

   Thank you for any and all help!
4. seratch commented on Mar 9, 2021

   

   seratch

   on Mar 9, 2021

   Contributor

   More actions

   Warning: the env vars x & y were found, so we created an installation_store object for you, but that conflicts with token, so token was ignore. Please remove one of those vars if you want to use token.

   This is a great suggestion! I will update the warning message for the case.

   Finally a quick architecture question. If an app is added to multiple workspaces, does a single App() call to bolt register them all at once? And then a need to look at both team_id and user_id in the callbacks?

   To handle multiple workspace installations, your App needs to implement the installation flow: https://slack.dev/bolt-python/concepts#authenticating-oauth . In addition, your App uses installation_store for determining a valid token in accordance with incoming request data (specifically, enterprise_id, team_id, user_id). In your listeners (or callbacks) like @app.action etc, you don't need to do anything as long as the authorize middleware that internally uses installation_store works properly. You can expect the token for workspace is set in client argument. Also, a few other attributes are set in context object this way.

   Or instead does one startup a new process, one process per workspace?

   No, you can handle requests from multiple workspaces with a single app.
5. rob-laddish commented on Mar 10, 2021

   

   rob-laddish

   on Mar 10, 2021

   Author

   More actions

   Perfect, thanks again for the great info!
6. rob-laddish

   closed this as completedon Mar 10, 2021
7. seratch

   added a commit that references this issue on Mar 11, 2021

   Improve the warning message in App/AsyncApp constructor #256

   4044d5a