Skip to content

Enable to use installation_store_bot_only flag not only as the top-level arg #177

Description

@seratch

With version 1.1.2, the newly added flag installation_store_bot_only works only when being set to the top-level field. The constructor's initialization needs to be smarter to check if the flag is set in the OAuthFlow / OAuthSettings level.

Reproducible in:

pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`

The slack_bolt version

version 1.1.2

Python runtime version

any

OS info

any

Steps to reproduce:

App(installation_store_bot_only=True)
App(oauth_flow=OAuthFlow(settings=OAuthSettings(installation_store_bot_only=True))
App(oauth_settings=OAuthSettings(installation_store_bot_only=True))

Expected result:

All the three examples should work in the same way.

Actual result:

Only the first one works as expected.

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Activity

  1. added this to the 1.1.3 milestone on Dec 9, 2020
  2. self-assigned this
    on Dec 9, 2020
  3. added a commit that references this issue on Dec 11, 2020
    d82a7d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions