Skip to content

Add metadata to response_url params #1819

Description

@ducminh-phan

Reproducible in:

The Slack SDK version

@slack/bolt@3.13.0

Node.js runtime version

v16.14.0

OS info

N/A

Steps to reproduce:

type ChatPostMessageArgumentsKnownKeys =
| 'token'
| 'channel'
| 'text'
| 'as_user'
| 'attachments'
| 'blocks'
| 'icon_emoji'
| 'icon_url'
| 'link_names'
| 'mrkdwn'
| 'parse'
| 'reply_broadcast'
| 'thread_ts'
| 'unfurl_links'
| 'unfurl_media'
| 'username';

Expected result:

There should be the key metadata as it seems to be supported. I have tested and metadata is sent successfully.

Actual result:

There is no key metadata

image

Activity

  1. added
    bugM-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
    and removed on May 1, 2023
  2. added this to the 3.13.2 milestone on May 1, 2023
  3. changed the title [-](Set a clear title describing the issue)[/-] [+]Add metadata to response_url params[/+] on May 1, 2023
  4. seratch commented on May 1, 2023

    @seratch
    Contributor

    Hi @ducminh-phan, thanks for taking the time to report this issue! You're right that metadata parameter must be allowed for response_url requests. We will resolve this issue in the next release.

  5. added a commit that references this issue on May 1, 2023
    9e0b8ac
  6. Joebayld commented on Aug 17, 2023

    @Joebayld

    I'm having an issue since this fix. It appears it's now requiring metadata to be in the response when it should be optional.
    image

  7. gfpacheco commented on Sep 6, 2023

    @gfpacheco

    @seratch any updates on this? I'm facing the same issue as @Joebayld

  8. seratch commented on Sep 7, 2023

    @seratch
    Contributor

    @gfpacheco @Joebayld Could you help me figure out how to reproduce the issue you've observed?

    I've never experienced the type errors in TS:

    One possibility is that some of your @slack/ prefixed packages could be quite old and that might cause unexpected type resolution (if that's that case, the minimum requried versions of underlying packages need to be improved). Please check the dependencies and try the latest versions for all of them.

  9. gfpacheco commented on Sep 7, 2023

    @gfpacheco

    @seratch you're right! After deleting node_modules and yarn.lock, and running yarn install again the error dissapeared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    TypeScript-specificbugM-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions