prepend fullImagePath with nextcloud path - #7
Merged
Merged
Conversation
Owner
|
That problem was introduced in the last PR. Thank you for catching that and opening up the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem I stumbled upon:
I had troubles getting MMM-RandomPhtoto to work with my Nextcloud share.
In the logs, I read the message "Invalid URL", and no matter what kind of WebDAV URL I used, it didn't work.
I took a look at the code, and found this:
Solution in this PR:
node_helper calls the http get with the fullImagePath, which, at this point, consists of only the fileName and extension.
I prepended the configured nextcloud Path, and with this change, I finally had images appearing on my Magic Mirror!
Thanks for this cool module!