Non-substantive changes per recommendations - #14
Merged
Merged
Conversation
Add repository and keywords
magic mirror > magicmirror2
new Date() > new Date(Date.now())
michmich > magicmirror
https > node:https
skuethe
requested changes
Mar 28, 2024
skuethe
requested changes
Mar 28, 2024
superscript 2
change version Co-authored-by: skuethe <56306041+skuethe@users.noreply.github.com>
Author
|
Suggestions committed |
skuethe
requested changes
Mar 29, 2024
spacing
skuethe
requested changes
Mar 29, 2024
| "author": "skuethe", | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "jquery": "^3.1.0" |
Owner
There was a problem hiding this comment.
Again having trouble to identify spaces via mobile app, but it seems you broke the indentation of this object. Should be 4 spaces for this childobject by respecting the 2 spaces of indentation for json files rule
Author
There was a problem hiding this comment.
Yes, my bad. I unindented both that and another one when I should have just done the other one. Fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-substantive changes as recommended here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-RandomPhoto-by-skuethe
The only quasi-substantive change is the
require("https")torequire("node:https")innode_helper.js. I'll confess I don't know the full scope of what this change does. I've tested it with Nextcloud, and it is working.The devs also recommend: