Skip to content

Remove requirement for having a package title #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nover merged 1 commit into from
Sep 30, 2021
Merged

Remove requirement for having a package title #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/CsProj/ProjectFileParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,7 @@ public virtual void Load(string xmlDocument, ProjectFileProperty property)
case ProjectFileProperty.Title:
var defaultPropertyElement = LoadProperty(ProjectFileProperty.PackageId);
PackageName = propertyElement?.Value ?? defaultPropertyElement?.Value ?? string.Empty;

if (string.IsNullOrEmpty(PackageName))
{
throw new ArgumentException(
"The provided csproj file seems malformed - no <Title> or <PackageId> in the <PropertyGroup>",
paramName: nameof(xmlDocument)
);
}


break;
}
}
Expand Down
8 changes: 2 additions & 6 deletions test/CsProj/ProjectFileParserTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,9 @@ public void Works_when_no_packageId_or_title()
"<RootNamespace>Unit.For.The.Win</RootNamespace>" +
"</PropertyGroup>" +
"</Project>";

var ex = Assert.Throws<ArgumentException>(() =>
parser.Load(csProjXml)
);

Assert.Contains($"The provided csproj file seems malformed - no <Title> or <PackageId> in the <PropertyGroup>", ex.Message);
Assert.Equal("xmlDocument", ex.ParamName);
parser.Load(csProjXml);
Assert.Empty(parser.PackageName);
}
}
}