Add support for custom decimal string formatter#125
Merged
Conversation
dmosorast
commented
Mar 3, 2021
dmosorast
left a comment
dmosorast
left a comment
Contributor
Author
There was a problem hiding this comment.
Turns out I can't request changes since I opened this PR, but these are "Requested Changes" heh
added 2 commits
March 3, 2021 19:30
…inger-io/singer-python into feature/decimal-formatted-string-types
dmosorast
commented
Mar 3, 2021
dmosorast
left a comment
dmosorast
left a comment
Contributor
Author
There was a problem hiding this comment.
One more change.
dmosorast
commented
Mar 3, 2021
dmosorast
left a comment
dmosorast
left a comment
Contributor
Author
There was a problem hiding this comment.
Looks good. Approved without actually being able to hit the checkbox, but I think this is good to go ✅ 
jacobrobertbaca
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR introduces a new concept: A Singer custom string format type that specifies a decimal value.
The reasoning behind this is to maintain decimal precision throughout ELT pipelines by converting to and from JSON strings and parsing with
decimal.Decimal(in Python).Manual QA steps
Risks
Rollback steps