Repository navigation
Add is.enumCase and assert.enumCase - #150
Merged
Merged
Conversation
sindresorhus
requested changes
Jan 16, 2022
is.enumCase and assert.enumCase
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Contributor
Author
|
Suggestions applied, thanks! |
Contributor
|
Hello, I think there should have been a test case to verify that |
Contributor
Author
|
I thought about added this in - but I noticed that none of the other test suites did the same, so I left it out. Happy to add this in if the maintainers see the value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148
Turns out typing this correctly was a bit trickier than I initially expected, since enums are both a value and a type.
Given this:
If
assert.enumCasewas typed to returnasserts value is T(T being the inferred type ofDirection), the asserted type ofinputwould becomestring & typeof Direction, which is no good.Typing it as
asserts value is T[keyof T]instead did the trick, makinginputbe typed asDirection.