Add React to peer dependencies - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package imports from
reactat runtime, butreactis currently only listed indevDependencies.With strict package managers such as pnpm, consumers can hit a runtime module resolution error when
ink-gradientis installed as a transitive dependency:This adds
reacttopeerDependencies, matching the runtime import and Ink's own peer dependency requirement.Verified with:
pnpm testI also verified the consumer failure case locally by installing
@vegamo/deepcode-cliin a temporary pnpm project and applying the same dependency metadata viapackageExtensions. Withreactincluded inink-gradient's peer dependency context,pnpm exec deepcode --helpruns successfully.