Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR fixes workflow viewport panning when copilot makes changes. The key improvements:
The implementation correctly handles:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Copilot
participant UseEffect1 as Queue Effect
participant SeenRef as seenDiffBlocksRef
participant PendingRef as pendingZoomBlockIdsRef
participant UseEffect2 as Pan Effect
participant Utils as getNodeAbsolutePosition
participant Viewport as fitViewToBounds
Copilot->>UseEffect1: diffAnalysis updates (new_blocks: [block1])
UseEffect1->>SeenRef: Check if block1 seen
SeenRef-->>UseEffect1: Not seen
UseEffect1->>SeenRef: Add block1
UseEffect1->>PendingRef: Set {block1}
UseEffect2->>PendingRef: Check pending blocks
PendingRef-->>UseEffect2: {block1}
UseEffect2->>UseEffect2: Verify block1 has dimensions
UseEffect2->>Utils: getNodeAbsolutePosition(block1)
Utils-->>UseEffect2: Absolute position
UseEffect2->>Viewport: Pan to block1 (absolute coords)
UseEffect2->>PendingRef: Clear pending
Note over Copilot: User accepts, copilot makes more changes
Copilot->>UseEffect1: diffAnalysis updates (new_blocks: [block2])
UseEffect1->>SeenRef: Check if block2 seen
SeenRef-->>UseEffect1: Not seen
UseEffect1->>SeenRef: Add block2
UseEffect1->>PendingRef: Set {block2}
UseEffect2->>PendingRef: Check pending blocks
PendingRef-->>UseEffect2: {block2}
UseEffect2->>UseEffect2: Verify block2 has dimensions
UseEffect2->>Utils: getNodeAbsolutePosition(block2)
Utils-->>UseEffect2: Absolute position
UseEffect2->>Viewport: Pan to block2 (absolute coords)
UseEffect2->>PendingRef: Clear pending
|
Collaborator
Author
|
@greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Solo.
Checklist