feat(executor): run from/until block #3029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
icecrasher321
approved these changes
Jan 28, 2026
Collaborator
icecrasher321
left a comment
icecrasher321
left a comment
There was a problem hiding this comment.
Tested all edge cases
Contributor
Greptile OverviewGreptile SummaryImplemented run-from-block and run-until-block execution features that allow users to execute workflows starting from a specific block or stopping after a target block. The implementation includes comprehensive validation, snapshot management, and UI integration. Key Changes:
Implementation Approach: Validation:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant UI as Block Menu
participant Hook as useWorkflowExecution
participant Stream as useExecutionStream
participant API as execute-from-block API
participant Core as execution-core
participant Executor as DAGExecutor
participant Engine as ExecutionEngine
participant Store as ExecutionStore
User->>UI: Right-click block, select "Run from block"
UI->>Hook: handleRunFromBlock(blockId)
Hook->>Store: getLastExecutionSnapshot(workflowId)
Store-->>Hook: Return snapshot
alt No snapshot or dependencies not satisfied
Hook-->>User: Show error notification
else Valid snapshot
Hook->>Stream: executeFromBlock(workflowId, startBlockId, snapshot)
Stream->>API: POST /api/workflows/{id}/execute-from-block
API->>API: Validate auth & request body
API->>Core: executeWorkflowCore(runFromBlock options)
Core->>Executor: executeFromBlock(workflowId, startBlockId, snapshot)
Executor->>Executor: validateRunFromBlock()
Executor->>Executor: computeExecutionSets()
Note over Executor: Compute dirty set (blocks to re-execute)<br/>and upstream set (cached blocks)
Executor->>Executor: Filter snapshot to reachable upstream
Executor->>Executor: Remove incoming edges from non-dirty sources
Executor->>Engine: run()
Engine->>Engine: initializeQueue(startBlockId)
loop Until no work remaining
Engine->>Engine: executeNodeAsync(nodeId)
alt Block in dirty set
Engine->>Engine: Re-execute block
else Block not in dirty set
Engine->>Engine: Use cached output
end
Engine->>API: Send SSE events (block:started, block:completed)
API->>Stream: Stream SSE events
Stream->>Hook: Trigger callbacks
Hook->>Store: Update execution state
Hook->>UI: Update active blocks visualization
end
Engine-->>Executor: Return ExecutionResult
Executor-->>Core: Return result
Core->>API: Send execution:completed event
API->>Stream: Stream final result
Stream->>Hook: onExecutionCompleted
Hook->>Store: setLastExecutionSnapshot() (merge with existing)
Hook->>UI: Update UI state
UI-->>User: Show execution complete
end
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| // Filter snapshot to include all blocks reachable from dirty blocks | ||
| // This preserves sibling branch outputs that dirty blocks may reference | ||
| const filteredBlockStates: Record<string, any> = {} |
Contributor
There was a problem hiding this comment.
type mismatch - filteredBlockStates is Record<string, any> but should match the type expected by blockStates field
Suggested change
| const filteredBlockStates: Record<string, any> = {} | |
| const filteredBlockStates: Record<string, BlockState> = {} |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/executor/execution/executor.ts
Line: 144:144
Comment:
type mismatch - `filteredBlockStates` is `Record<string, any>` but should match the type expected by `blockStates` field
```suggestion
const filteredBlockStates: Record<string, BlockState> = {}
```
How can I resolve this? If you propose a fix, please make it concise.| isDeployedContext: this.contextExtensions.isDeployedContext, | ||
| blockStates: state.getBlockStates(), | ||
| blockLogs: snapshotState?.blockLogs ?? [], | ||
| blockLogs: overrides?.runFromBlockContext ? [] : (snapshotState?.blockLogs ?? []), |
Contributor
There was a problem hiding this comment.
when runFromBlockContext exists, blockLogs are reset to empty array, but this discards upstream execution logs that may be needed for debugging and tracing
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/executor/execution/executor.ts
Line: 268:268
Comment:
when `runFromBlockContext` exists, `blockLogs` are reset to empty array, but this discards upstream execution logs that may be needed for debugging and tracing
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+1656
to
+1661
| const mergedBlockStates: Record<string, BlockState> = { | ||
| ...effectiveSnapshot.blockStates, | ||
| } | ||
| for (const [bId, state] of accumulatedBlockStates) { | ||
| mergedBlockStates[bId] = state | ||
| } |
Contributor
There was a problem hiding this comment.
merging logic doesn't preserve loop/parallel execution state from the snapshot - only blockStates are merged but loopExecutions and parallelExecutions from effectiveSnapshot should also be included in updatedSnapshot
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-workflow-execution.ts
Line: 1656:1661
Comment:
merging logic doesn't preserve loop/parallel execution state from the snapshot - only `blockStates` are merged but `loopExecutions` and `parallelExecutions` from `effectiveSnapshot` should also be included in `updatedSnapshot`
How can I resolve this? If you propose a fix, please make it concise.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds run from block and run until block functionality to the executor
Type of Change
Testing
Tested with @icecrasher321
Checklist