Skip to content

improvement(workflow): hide raw json childworkflow span #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 1 commit into from
Jan 27, 2026
Merged

improvement(workflow): hide raw json childworkflow span #3019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions apps/sim/executor/execution/block-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
EDGE,
isSentinelBlockType,
isTriggerBehavior,
isWorkflowBlockType,
} from '@/executor/constants'
import type { DAGNode } from '@/executor/dag/builder'
import { ChildWorkflowError } from '@/executor/errors/child-workflow-error'
Expand Down Expand Up @@ -154,8 +155,8 @@ export class BlockExecutor {
this.state.setBlockOutput(node.id, normalizedOutput, duration)

if (!isSentinel) {
const filteredOutput = this.filterOutputForLog(block, normalizedOutput)
this.callOnBlockComplete(ctx, node, block, resolvedInputs, filteredOutput, duration)
const displayOutput = this.filterOutputForDisplay(block, normalizedOutput)
this.callOnBlockComplete(ctx, node, block, resolvedInputs, displayOutput, duration)
}

return normalizedOutput
Expand Down Expand Up @@ -245,7 +246,8 @@ export class BlockExecutor {
)

if (!isSentinel) {
this.callOnBlockComplete(ctx, node, block, input, errorOutput, duration)
const displayOutput = this.filterOutputForDisplay(block, errorOutput)
this.callOnBlockComplete(ctx, node, block, input, displayOutput, duration)
}

const hasErrorPort = this.hasErrorPortEdge(node)
Expand Down Expand Up @@ -337,7 +339,9 @@ export class BlockExecutor {
block: SerializedBlock,
output: NormalizedBlockOutput
): NormalizedBlockOutput {
if (block.metadata?.id === BlockType.HUMAN_IN_THE_LOOP) {
const blockType = block.metadata?.id

if (blockType === BlockType.HUMAN_IN_THE_LOOP) {
const filtered: NormalizedBlockOutput = {}
for (const [key, value] of Object.entries(output)) {
if (key.startsWith('_')) continue
Expand All @@ -360,6 +364,22 @@ export class BlockExecutor {
return output
}

private filterOutputForDisplay(
block: SerializedBlock,
output: NormalizedBlockOutput
): NormalizedBlockOutput {
const filtered = this.filterOutputForLog(block, output)

if (isWorkflowBlockType(block.metadata?.id)) {
const { childTraceSpans: _, ...displayOutput } = filtered as {
childTraceSpans?: unknown
} & Record<string, unknown>
return displayOutput
}

return filtered
}

private callOnBlockStart(ctx: ExecutionContext, node: DAGNode, block: SerializedBlock): void {
const blockId = node.id
const blockName = block.metadata?.name ?? blockId
Expand Down