Skip to content

fix(logs): refresh logic to refresh logs details #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emir-karabeg merged 1 commit into from
Jan 24, 2026
Merged

fix(logs): refresh logic to refresh logs details #2958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions apps/sim/app/workspace/[workspaceId]/logs/logs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ export default function Logs() {
const [previewLogId, setPreviewLogId] = useState<string | null>(null)

const activeLogId = isPreviewOpen ? previewLogId : selectedLogId
const activeLogQuery = useLogDetail(activeLogId ?? undefined)
const activeLogQuery = useLogDetail(activeLogId ?? undefined, {
refetchInterval: isLive ? 3000 : false,
})

const logFilters = useMemo(
() => ({
Expand All @@ -113,7 +115,7 @@ export default function Logs() {

const logsQuery = useLogsList(workspaceId, logFilters, {
enabled: Boolean(workspaceId) && isInitialized.current,
refetchInterval: isLive ? 5000 : false,
refetchInterval: isLive ? 3000 : false,
})

const dashboardFilters = useMemo(
Expand All @@ -132,7 +134,7 @@ export default function Logs() {

const dashboardStatsQuery = useDashboardStats(workspaceId, dashboardFilters, {
enabled: Boolean(workspaceId) && isInitialized.current,
refetchInterval: isLive ? 5000 : false,
refetchInterval: isLive ? 3000 : false,
})

const logs = useMemo(() => {
Expand Down Expand Up @@ -160,12 +162,6 @@ export default function Logs() {
}
}, [debouncedSearchQuery, setStoreSearchQuery])

useEffect(() => {
if (!isLive || !selectedLogId) return
const interval = setInterval(() => activeLogQuery.refetch(), 5000)
return () => clearInterval(interval)
}, [isLive, selectedLogId, activeLogQuery])

const handleLogClick = useCallback(
(log: WorkflowLog) => {
if (selectedLogId === log.id && isSidebarOpen) {
Expand Down Expand Up @@ -279,8 +275,11 @@ export default function Logs() {
setIsVisuallyRefreshing(true)
setTimeout(() => setIsVisuallyRefreshing(false), REFRESH_SPINNER_DURATION_MS)
logsQuery.refetch()
if (selectedLogId) {
activeLogQuery.refetch()
}
}
}, [isLive, logsQuery])
}, [isLive, logsQuery, activeLogQuery, selectedLogId])

const prevIsFetchingRef = useRef(logsQuery.isFetching)
useEffect(() => {
Expand Down
10 changes: 8 additions & 2 deletions apps/sim/hooks/queries/logs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,17 @@ export function useLogsList(
})
}

export function useLogDetail(logId: string | undefined) {
interface UseLogDetailOptions {
enabled?: boolean
refetchInterval?: number | false
}

export function useLogDetail(logId: string | undefined, options?: UseLogDetailOptions) {
return useQuery({
queryKey: logKeys.detail(logId),
queryFn: () => fetchLogDetail(logId as string),
enabled: Boolean(logId),
enabled: Boolean(logId) && (options?.enabled ?? true),
refetchInterval: options?.refetchInterval ?? false,
staleTime: 30 * 1000,
placeholderData: keepPreviousData,
})
Expand Down