Repository navigation
fix: harden ManifestServerUrlResolver against SSRF - #18
Merged
FllipEis merged 1 commit intoSep 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
The SDK downloads the manifest
server_versions.jsonfromSIMPLECLOUD_SERVER_VERSION_MANIFEST_URLwithout an SSRF guard.Any plugin sharing the JVM can make http://127.0.0.1/... or http://254.254.254.254/... fetching and propagate the link to the controller (SSRF relay).
Fix:
Root cause
OkHttp.newCall(request).execute()with auto redirect and no limitapiRequest.setServerUrl()Tests
ManifestServerUrlResolverTest: addshouldRejectHttpManifestUrl,shouldRejectPrivateDownloadLink,shouldCapRedirects,shouldCapManifestSize.Btw: https://docs.simplecloud.app/contribute redirect to the github orga page so can't read if their is needs.