Skip to content

Fix output block closing fence when content lacks trailing newline #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vorou wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix output block closing fence when content lacks trailing newline #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion markdown/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ func writeBlock(w io.Writer, block Block) error {
return err
case OutputBlock:
fence := fenceFor(b.Content)
_, err := fmt.Fprintf(w, "%soutput\n%s%s\n", fence, b.Content, fence)
sep := ""
if b.Content != "" && !strings.HasSuffix(b.Content, "\n") {
sep = "\n"
}
_, err := fmt.Fprintf(w, "%soutput\n%s%s%s\n", fence, b.Content, sep, fence)
return err
case ImageOutputBlock:
_, err := fmt.Fprintf(w, "![%s](%s)\n", b.AltText, b.Filename)
Expand Down
15 changes: 15 additions & 0 deletions markdown/writer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,21 @@ func TestWriteOutputNoBackticks(t *testing.T) {
}
}

func TestWriteOutputNoTrailingNewline(t *testing.T) {
var buf strings.Builder
blocks := []Block{
OutputBlock{Content: "hello"},
}
err := Write(&buf, blocks)
if err != nil {
t.Fatal(err)
}
expected := "```output\nhello\n```\n"
if buf.String() != expected {
t.Errorf("expected:\n%q\ngot:\n%q", expected, buf.String())
}
}

func TestWriteTitleWithDocumentID(t *testing.T) {
var buf strings.Builder
blocks := []Block{
Expand Down