Made fixes to accessibility and returning back to a page after a time up or answered questions - #4
Made fixes to accessibility and returning back to a page after a time up or answered questions#4mike-st wants to merge 67 commits into
Conversation
|
@mike-st , thank you so much for creating such a detailed PR for a component that I haven't touched in almost three years. When I get a chance I will review it and merge it in. But thanks so much! |
|
Thanks so much Simon! Great work again on this one. Saved my hid for a client job I was working on. I had slightly over looked some things in the last push, without properly testing accessibility and when a person navigates back to the timed MCQ from the menu when it has been previously answered or timed out. Fixes should help make it more accommodating going on. |
|
Likewise your menu was exactly what one of my clients requested. Pretty cool coincidence 😄 I have also made a few improvements on my fork of it. So when I'm finished I'll create a PR too! As for this one I'll wait til my work dies down a bit and I will test locally before merging. |
|
Sounds good and that is great I could help out with the menu for you too. Thanks for making some improvements too. Looking forward to checking them out, much appreciated. My strengths are a little more CSS/LESS so hopefully my js wasn't too messy. |
2 participants
No description provided.