Repository navigation
Preserve dictation endings and filter recognized sound labels - #1107
Draft
silverstein wants to merge 3 commits into
Draft
silverstein wants to merge 3 commits into
silverstein wants to merge 3 commits into
Conversation
silverstein
changed the base branch from
fix/mcp-dictation-control-20261007
to
main
October 7, 2026 17:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping dictation during a blocking partial transcription can leave completed microphone chunks unread, cutting off the ending. Nearby typing can also produce a sound label such as
(keyboard clacking)inside an otherwise correct transcript.Stop and yield-to-recording now share one finalization path. Capture closes before its queued chunks are drained into the recovery recording and final decoder, without running more partial transcriptions during drain. Cancellation continues to discard audio and text, including cancellation during the final decode.
Dictation cleanup removes a narrow list of recognized bracketed or parenthesized keyboard/music labels and preserves the surrounding speech. Ordinary parentheses, nested content, quoted labels and explicit raw mode remain intact. Terminal mode preserves code formatting and ambiguous single-word tags.
Three queue/silence regressions cover a 2.4-second speech backlog, trailing silence, and silence without speech. Five sound-label regressions cover the exact observed phrase, adjacent labels, quoted/ordinary content, code/raw modes and malformed nesting. CI now executes the Whisper-enabled dictation and streaming decoder suites on all three platforms.
This branch includes the dictation control repair in #1105; those changes remain separately reviewable there. The PR targets main so the full required CI matrix runs. Rebase onto main after #1105 lands before merging this remaining change.
Validation: Mac Rust 1.95 formatting and strict workspace Clippy pass. The current sound-label cleanup suite passes 30 tests. The prior queued-audio candidate passed the required serial core suite (1,925 tests, one ignored), 27 dictation/cancellation tests and seven streaming decoder tests with the exact new CI filters. Its release CLI builds with parakeet + metal and reports dictation_addressed_stop_v1=true. Workflow lint, version sync and strict site release constants pass. Final serial core validation for the sound-label update passes 1,930 tests (one ignored).
Native limits: signed installed Dev identity and hotkey are verified; actual private MCP addressed-stop requests ended two native sessions while preserving the app. One microphone trial truncated the phrase and a second retained the complete ending, so repeatable native accuracy remains unverified. The second result also pasted into a changed active app while the user typed. Microphone/desktop tests are paused. The new sound-label filter is source-tested and has not been installed or qualified in the native app. Actual ChatGPT capture remains pending; this is a draft.