Skip to content

[claude] Show activity as a list-detail view - #2894

Open
myieye wants to merge 8 commits into
developfrom
ccr-ec763e0b-axel8b
Open

myieye wants to merge 8 commits into
developfrom
ccr-ec763e0b-axel8b

Conversation

@myieye

@myieye myieye commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator

[Claude, autonomous]

Activity now uses the shared MasterDetailView from Browse, so it gets the same resizable split, URL-driven selection (commitId/commitOpen) and back-button behavior. On mobile, a tapped row opens full-screen with the entry view's X button.

  • Desktop still opens on the newest commit. It's derived rather than written to the URL, so it adds no history entry.
  • Brings over from the old step-6 branch (claude/activity-6-list-detail-layout): the error boundary, the empty-detail prompt and the 35/65 split. That branch's hand-rolled ListDetailLayout is dropped in favor of MasterDetailView.
  • No Playwright test: the in-browser demo has no history service. I checked desktop/mobile selection, X, and back in Chromium against FwLiteWeb.

Activity part 5/8.

Screenshots

Desktop Mobile list Mobile detail

Generated by Claude Code

claude and others added 8 commits November 1, 2026 15:15
Activity now uses the same responsive shell and navigation as Browse. The
selected commit lives in the URL (commitId/commitOpen). Desktop shows the
newest commit until one is picked, without pushing history. On mobile, a tapped
row opens the detail full-screen with the entry view's close button, and back
returns to the list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AM78WDGC4Q4767udRRmNrC
…ng in mobile detail

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AM78WDGC4Q4767udRRmNrC
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9b058a6e-7b33-46bb-8f0e-32aaa9891d3e
Commits

Reviewing files that changed from the base of the PR and between 4c0f31f and 70f83dc.

Files selected for processing: 11
  • frontend/viewer/src/lib/activity/ActivityItem.svelte
  • frontend/viewer/src/lib/activity/ActivityView.svelte
  • frontend/viewer/src/lib/utils/search-params.ts
  • frontend/viewer/src/locales/en.po
  • frontend/viewer/src/locales/es.po
  • frontend/viewer/src/locales/fr.po
  • frontend/viewer/src/locales/id.po
  • frontend/viewer/src/locales/ko.po
  • frontend/viewer/src/locales/ms.po
  • frontend/viewer/src/locales/sw.po
  • frontend/viewer/src/locales/vi.po

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Activity view now uses a master-detail layout with commit selection and pane state linked to URL parameters. Desktop selects the first visible commit by default; mobile does not. The detail pane includes close, loading, and empty-selection states, and the view is wrapped in an error boundary. Activity items can display a close button. Locale catalogs gained strings for the error and empty-selection states; translations are blank in the listed non-English catalogs.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: hahn-kev

Merge Risk: Low · up to 70f83

Reloading a link to an older activity item may show the newest item or an empty detail pane. Users can recover by finding the item in the list, so this is mergeable with owner awareness.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly describes the primary change: Activity now uses a list-detail view.
Description check Passed The description directly explains the Activity view changes, including MasterDetailView integration, URL-driven selection, responsive behavior, and testing performed.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (10 skipped: 10 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit clicks through commits bright,
The detail pane swings into sight.
A close button waits beside the view,
While URL paths keep choices true.
The bunny hops, then rests in cheer,
New prompts and states now gather here.

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Nov 1, 2026
@argos-ci

argos-ci Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Nov 1, 2026, 3:26 PM

@myieye
myieye marked this pull request as ready for review November 1, 2026 15:29

myieye commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

myieye commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants