Add dependent root check to proposer preferences validation (alpha.13) by eserilev · Pull Request #9760 · sigp/lighthouse

eserilev · 2026-08-06T06:45:52Z

Issue Addressed

mergify · 2026-08-06T07:07:17Z

Some required checks have failed. Could you please take a look @eserilev? 🙏

mergify · 2026-08-06T08:33:35Z

Some required checks have failed. Could you please take a look @eserilev? 🙏

pawanjay176 · 2026-08-06T22:47:57Z

+            });
+        }
+
+        let proto_array = fork_choice_read.proto_array().core_proto_array();


Can this entire logic not live in a fork choice instead?

chong-he

I can see that the 2 checks in ethereum/consensus-specs#5443 are added in this PR. Specifically:

check for the dependent_root slot to be < start slot of an epoch (strictly less than), or Lighthouse will return error: DependentRootToRecent
check for function is_valid_dependent_root, failing which Lighthouse will return error: InvalidDependentRoot

Looks great overall, just some minor comments.

chong-he

Nice, I see that Pawan's comment has been addressed where the get children code is moved to fork_choice.rs, which is cleaner.

pawanjay176

Nice, LGTM.

mergify · 2026-08-12T22:30:51Z

Queued — the merge queue status continues in this comment ↓.

mergify · 2026-08-17T18:21:28Z

Merge Queue Status

✅ Entered queue — 2026-08-17 18:21 UTC · Rule: default · triggered by the @mergifyio queue command
❌ Checks failed — 2026-08-17 18:23 UTC · on draft merge queue: checking unstable (3ea7c47) and [#9760 + #9761 + #9763] together #9833
✂️ Bisecting to identify the failing PR (round 1/1)
❌ Checks failed · on draft merge queue: checking unstable (3ea7c47) and #9760 together #9834 · identified as the failing PR
🚫 Left the queue — 2026-08-17 19:14 UTC · at da61d0b5d7d425198596dd2a924522e86e995775

This pull request spent 53 minutes 21 seconds in the queue, including 20 minutes 12 seconds running CI.

Reason

Pull request #9760 has been dequeued by @pawanjay176 with a dequeue command

Requeued — the merge queue status continues in this comment ↓.

pawanjay176 · 2026-08-17T19:13:35Z

@mergify dequeue

mergify · 2026-08-17T19:17:21Z

Merge Queue Status

🛑 Queue command has been cancelled

pawanjay176 · 2026-08-17T20:58:41Z

@mergify dequeue

mergify · 2026-08-17T21:02:33Z

Merge Queue Status

✅ Entered queue — 2026-08-17 21:02 UTC · Rule: default · triggered by the @mergifyio queue command
❌ Checks failed — 2026-08-17 21:34 UTC · on draft merge queue: checking unstable (3ea7c47) and [#9760 + #9761 + #9763] together #9836
✂️ Bisecting to identify the failing PR (round 1/1)
✅ Checks passed · on draft merge queue: checking unstable (3ea7c47) and #9760 together #9837
✅ Merged — 2026-08-17 22:26 UTC · at da61d0b5d7d425198596dd2a924522e86e995775 · squash

This pull request spent 1 hour 24 minutes 3 seconds in the queue, including 50 minutes 56 seconds running CI.

Required conditions to merge

check-success=local-testnet-success
check-success=test-suite-success
github-review-approved [🛡 GitHub branch protection]
- Add dependent root check to proposer preferences validation (alpha.13) #9760

eserilev requested a review from jxs as a code owner August 6, 2026 06:45

eserilev added gloas ready-for-review The code is ready for review labels Aug 6, 2026

mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 6, 2026

eserilev force-pushed the gloas-proposer-prefs-dependent-root branch from 6557de5 to dcecf6b Compare August 6, 2026 07:36

eserilev changed the base branch from unstable to ef-tests-target-branch-rule August 6, 2026 07:53

mergify Bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 6, 2026

eserilev force-pushed the gloas-proposer-prefs-dependent-root branch from dcecf6b to d5d70b0 Compare August 6, 2026 08:32

mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 6, 2026

eserilev force-pushed the gloas-proposer-prefs-dependent-root branch from d5d70b0 to f56251b Compare August 6, 2026 08:35

pawanjay176 mentioned this pull request Aug 6, 2026

Fix payload availability lookup using the parent block's slot (alpha.13) #9761

Merged

pawanjay176 changed the base branch from ef-tests-target-branch-rule to unstable August 6, 2026 21:17

pawanjay176 requested changes Aug 6, 2026

View reviewed changes

eserilev force-pushed the gloas-proposer-prefs-dependent-root branch from 08ce7ae to 0a1c104 Compare August 7, 2026 05:25

chong-he reviewed Aug 10, 2026

View reviewed changes

Comment thread beacon_node/beacon_chain/src/proposer_preferences_verification/mod.rs Outdated

Comment thread beacon_node/beacon_chain/src/proposer_preferences_verification/tests.rs Outdated

eserilev force-pushed the gloas-proposer-prefs-dependent-root branch from 40fd451 to d92f47e Compare August 10, 2026 08:40

chong-he approved these changes Aug 10, 2026

View reviewed changes

eserilev force-pushed the gloas-proposer-prefs-dependent-root branch 3 times, most recently from 85ba2b1 to fa000a4 Compare August 12, 2026 11:26

pawanjay176 approved these changes Aug 12, 2026

View reviewed changes

eserilev force-pushed the gloas-proposer-prefs-dependent-root branch from fa000a4 to 6cdb51b Compare August 13, 2026 10:56

eserilev force-pushed the gloas-proposer-prefs-dependent-root branch from 6a0c168 to da61d0b Compare August 17, 2026 12:33

mergify Bot mentioned this pull request Aug 17, 2026

Bump EF tests to v1.7.0-alpha.13 #9764

Merged

mergify Bot added the queued label Aug 17, 2026

mergify Bot added dequeued and removed dequeued labels Aug 17, 2026

pawanjay176 added skip-ci Don't run the `test-suite` ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 17, 2026

mergify Bot added dequeued and removed queued labels Aug 17, 2026

mergify Bot added queued and removed dequeued labels Aug 17, 2026

This was referenced Aug 17, 2026

merge queue: checking unstable (3ea7c47) and [#9760 + #9761 + #9763] together #9836

Closed

merge queue: checking unstable (3ea7c47) and #9760 together #9837

Closed

merge queue: checking unstable (3ea7c47), #9760 and #9761 together #9838

Closed

mergify Bot merged commit 44264fc into unstable Aug 17, 2026
38 checks passed

mergify Bot removed the queued label Aug 17, 2026

Conversation

eserilev commented Aug 6, 2026 • edited by pawanjay176 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Addressed

Uh oh!

mergify Bot commented Aug 6, 2026

Uh oh!

mergify Bot commented Aug 6, 2026

Uh oh!

pawanjay176 Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

eserilev Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

chong-he left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chong-he left a comment

Choose a reason for hiding this comment

Uh oh!

pawanjay176 left a comment

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Uh oh!

pawanjay176 commented Aug 17, 2026

Uh oh!

mergify Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

pawanjay176 commented Aug 17, 2026

Uh oh!

mergify Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eserilev commented Aug 6, 2026 •

edited by pawanjay176

Loading

mergify Bot commented Aug 12, 2026 •

edited

Loading

mergify Bot commented Aug 17, 2026 •

edited

Loading

mergify Bot commented Aug 17, 2026 •

edited

Loading

mergify Bot commented Aug 17, 2026 •

edited

Loading