Run Gloas sync tests instead of skipping them#9446
Open
dapplion wants to merge 4 commits into
Open
Conversation
Make the range, coupling and lookup sync tests exercise the Gloas path under FORK_NAME=gloas rather than early-returning. Fix the test harness to process Gloas payload envelopes during local-head import and drop the redundant per-root envelope cache (the RangeSyncBlock already carries it).
Split block_in_da_checker_skips_download into _fulu and _gloas variants. The Gloas version uses the parent-of-full-child idiom: insert the parent into the da_checker and trigger via a FULL child, so the parent lookup skips the parent block download while its columns/envelope are served by the child's peers. Restrict happy_path_unknown_data_parent to Fulu, since the UnknownDataColumnParent trigger does not exist post-Gloas.
Make the custody-column coupling tests single fork-agnostic bodies instead of branching on FORK_NAME. Collapse the duplicated Gloas no_blobs branch and the repeated inline envelope assertions into one assert_custody_columns_coupled helper, add a BlockColumnsEnvelope type alias to drop the type_complexity allows, and thread NumBlobs through make_blocks_and_columns.
|
Some required checks have failed. Could you please take a look @dapplion? 🙏 |
mergify
Bot
added
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9155 and #9362 left a bunch of sync tests early-returning under Gloas. Most of them work fine now, so this unskips the range sync, column coupling, and a couple of lookup tests so they actually run under FORK_NAME=gloas. Needed a small harness fix to process Gloas payload envelopes when building a local head, and that let me drop the redundant per-root envelope cache since the RangeSyncBlock already carries it. A couple stay skipped where Gloas genuinely differs (columns have no per-column proposer signature) or the da_checker missing-component path isn't wired yet — both noted in the code.
AI disclosure
Written by claude on the prompt: "Run the tests skipped by #9155". I have reviewed all lines