Add SSZ response to HTTP API endpoints - #8907
Conversation
|
Thanks for working on this. Can you write tests for the ssz routes? There's examples in the codebase for other ssz routes we test that you can use as an example |
Sure! Doing so |
|
CI is failing, can you address it @PoulavBhowmick03? Thanks Edit: looks like it is due to an update in cargo sort that causes it to fail. please ignore it. |
chong-he
left a comment
There was a problem hiding this comment.
I have tested the endpoints and they are working.
I think we should also add the SSZ-equivalent test for: test_get_validator_attestation_data and test_beacon_states_validator_identities as well. Would be great to have those tests
…tes_validator_identities
|
@chong-he do take a look again! thanks |
chong-he
left a comment
There was a problem hiding this comment.
Thanks for the changes, I can see the tests are added, but I got another comment as below. I am sorry for another back-and-forth as I should have identified this and commented in the last review but I didn't realize this back then.
|
CI is failing You can run the test locally: |
chong-he
left a comment
There was a problem hiding this comment.
I just did a very minor rearrange for the function post_bytes_opt_accept_header so that all the post_with_timeout_* are together.
This PR looks great now. Thanks for sticking on it.
|
merge conflict if you have time to resolve, that will be great @PoulavBhowmick03 |
Fixed the merge conflicts! |
|
Some required checks have failed. Could you please take a look @PoulavBhowmick03? 🙏 |
|
Some more conflicts to resolve @PoulavBhowmick03 |
|
Hi @PoulavBhowmick03, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time. |
|
Queued — the merge queue status continues in this comment ↓. |
Merge Queue Status
This pull request spent 30 minutes 51 seconds in the queue, including 29 minutes 19 seconds running CI. Required conditions to merge
|
Issue Addressed
Closes #8892
Proposed Changes
Adds SSZ response support to several endpoints for Beacon API spec compliance.