Skip to content

Add CI job to check for deleted files#8727

Merged
mergify[bot] merged 3 commits into
sigp:unstablefrom
michaelsproul:forbidden-files
Feb 26, 2026
Merged

Add CI job to check for deleted files#8727
mergify[bot] merged 3 commits into
sigp:unstablefrom
michaelsproul:forbidden-files

Conversation

@michaelsproul

@michaelsproul michaelsproul commented Feb 2, 2026

Copy link
Copy Markdown
Member

Add a job to CI that checks for deleted files which have accidentally been re-added. It seems that every time we delete a major component, it inevitably gets brought back from the dead by a merge conflict.

e.g.

The OTB verification service was deleted here:

Then re-added here:

Then re-deleted here:

The same thing happened with PartialBeaconState recently too.

Additional Info

Adding to .gitignore isn't strong enough, as git will still try to resolve conflicts for files that are on one branch and ignored on the other.

@michaelsproul michaelsproul added ready-for-review The code is ready for review infra-ci labels Feb 2, 2026
@michaelsproul

Copy link
Copy Markdown
Member Author

Expecting this to fail (due to OTB) until Lion's PR is merged.

@mergify

mergify Bot commented Feb 2, 2026

Copy link
Copy Markdown

Some required checks have failed. Could you please take a look @michaelsproul? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Feb 2, 2026
@dapplion

dapplion commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

Will we remember to add new deleted files in this list?

@michaelsproul

Copy link
Copy Markdown
Member Author

I will 😁

@michaelsproul

Copy link
Copy Markdown
Member Author

At least it's easier than remembering to check every PR for random files coming back from the dead

@michaelsproul

Copy link
Copy Markdown
Member Author

Another candidate:

  • beacon_node/store/src/consensus_context.rs

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! and removed blocked waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 25, 2026
@dapplion dapplion added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 26, 2026
@mergify mergify Bot added the queued label Feb 26, 2026
@mergify

mergify Bot commented Feb 26, 2026

Copy link
Copy Markdown

Merge Queue Status

Rule: default


This pull request spent 33 minutes 2 seconds in the queue, including 30 minutes 47 seconds running CI.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify Bot added a commit that referenced this pull request Feb 26, 2026
@mergify mergify Bot merged commit 2f43d23 into sigp:unstable Feb 26, 2026
37 checks passed
@mergify mergify Bot removed the queued label Feb 26, 2026
@michaelsproul michaelsproul deleted the forbidden-files branch February 26, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra-ci low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants