Disable LevelDB snappy feature#7235
Merged
Merged
Conversation
michaelsproul
added
ready-for-review
michaelsproul
added
ready-for-merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Disable the
snappyfeature of LevelDB to prevent compilation issues with CMake 4.0, e.g.https://github.com/sigp/lighthouse/actions/runs/14182783816/job/39732457274?pr=7231
We do not use Snappy compression in LevelDB, and do not need to compile this. This might also shave a few seconds off compilation!
Additional Info
I thought maybe we'd need to bump the LevelDB version -- an old change of mine from here:
But that PR doesn't actually fix the issue because it doesn't update the real culprit: the bundled version of
snappy.In future if we need more changes to LevelDB I think we'll have to release from our own fork, as the upstream Rust crates are essentially unmaintained.
I will merge this to
release-v7.0.0and then to unstable to unblock CI.