Reuse milhouse subtrees to shrink inactivity_scores in memory#7062
Merged
Conversation
a6bf424 to
b3b4678
Compare
intra_rebase to shrink inactivity_scores in memory
intra_rebase to shrink inactivity_scores in memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a new Milhouse method called
intra_rebaseto reuse identical subtrees ininactivity_scores. This reduces the memory used by eachinactivity_scoresupdate from ~70MB+ to ~4-5MB.To update to
milhouse'smainbranch I needed to steal Paul's changes from this PR, which I squashed into a single commit to make it easier to remove unwanted changes fromunstable:SmallVec#6915I tested this change using an even hackier branch here, which includes the Milhouse
mem-usagechanges: https://github.com/michaelsproul/lighthouse/tree/milhouse-mem-size-holesky-rescueCommand for testing:
Results: