Fix builder API headers#7009
Merged
Merged
Conversation
pawanjay176
added
do-not-merge
builder API
electra
Member
|
let's target this at the release-v7.0.0-beta.0 branch, which we'll use for future releases too (I should rename the branch most likely) |
pawanjay176
force-pushed
the
fix-builder-api
branch
2 times, most recently
from
1e2593b to
d131e1d
Compare
pawanjay176
added
ready-for-review
Member
Author
|
Tested this with lighthouse and other CL clients with the mock builder and ssz support works as expected. |
michaelsproul
changed the base branch from
unstable
to
release-v7.0.0-beta.0
michaelsproul
changed the base branch from
release-v7.0.0-beta.0
to
release-v7.0.0
michaelsproul
force-pushed
the
fix-builder-api
branch
from
dc3f870 to
f931c16
Compare
Member
|
Nice, ty. Rebased on a new branch called |
michaelsproul
approved these changes
Feb 20, 2025
michaelsproul
left a comment
michaelsproul
left a comment
Member
There was a problem hiding this comment.
Nice, substance looks good, just a few formatting nits
michaelsproul
added
waiting-on-author
Co-authored-by: Michael Sproul <michael@sigmaprime.io>
eserilev
reviewed
Feb 21, 2025
michaelsproul
added
ready-for-merge
mergify Bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
I keep being notified for PR's like #7009 where it doesn't touch the specified directories in the `CODEOWNERS` file. After reading the [docs](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners) not having a forward slash in beginning of the path means: > In this example, @octocat owns any file in an apps directory > anywhere in your repository. whereas with the slashes: > In this example, @doctocat owns any file in the `/docs` > directory in the root of your repository and any of its > subdirectories. this update makes it more rigid for the files in the jxs ownership
eserilev
pushed a commit
to eserilev/lighthouse
that referenced
this pull request
Mar 5, 2025
I keep being notified for PR's like sigp#7009 where it doesn't touch the specified directories in the `CODEOWNERS` file. After reading the [docs](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners) not having a forward slash in beginning of the path means: > In this example, @octocat owns any file in an apps directory > anywhere in your repository. whereas with the slashes: > In this example, @doctocat owns any file in the `/docs` > directory in the root of your repository and any of its > subdirectories. this update makes it more rigid for the files in the jxs ownership
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #7000
Proposed Changes
Set the accept header on builder to the correct value when requesting ssz.
This PR also adds a flag to disable ssz over the builder api altogether. In the case that builders/relays have an ssz bug, we can react quickly by asking clients to restart their nodes with the
--disable-ssz-builderflag to force json. I'm not fully convinced if this is useful so open to removing it or opening another PR for it.Testing this currently.