Add data columns by root sync request#6274
Merged
Merged
Conversation
dapplion
added
ready-for-review
This was referenced Aug 16, 2024
realbigsean
approved these changes
Aug 20, 2024
realbigsean
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 677f96a |
5 tasks
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
* Add data columns by root sync request
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Add data columns by root sync request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Part of
dastounstable#6072Proposed Changes
Add support inside sync network context to issue, track and complete
data_columns_by_rootrequests.This type of request will be issued by a higher order custody by root request. In summary:
The handler of
data_columns_by_rootrequests is quasi-identical toblobs_by_rootrequest handler. Same verify conditions and completeness conditions.