Import gossip data column into data availability checker#6197
Merged
Conversation
jimmygchen
added
ready-for-review
jimmygchen
force-pushed
the
import-gossip-data-columns
branch
from
eee188f to
026f759
Compare
jimmygchen
force-pushed
the
import-gossip-data-columns
branch
from
026f759 to
f29245e
Compare
dapplion
approved these changes
Aug 1, 2024
jimmygchen
added
ready-for-merge
Member
Author
|
@dapplion Thanks for the review! I've also just re-reviewed the code and made sure there's no impact on current mainnet code path, so we're safe to merge this one. |
Member
Author
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at acd3151 |
5 tasks
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Import gossip data column into data availability checker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Part of #6072
Wiring up gossip data column handling with data availability checker, and add
data_columnstoAvailableBlockfor storage later. (depends on #6073)Proposed Changes
Upstream PR from
dasbranch:DataColumnSidecarsByRootreq/resp protocol #5196