Repository navigation
fix (core/tab-item): show ellipsed text for layout=stretched (Ix-68) - #2680
Conversation
🦋 Changeset detectedLatest commit: 755de83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ix-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe stretched tab item styling now constrains nested ChangesTab item styling
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/core/src/components/tab-item/tab-item.scss`:
- Around line 118-122: Add a changeset for the user-facing styling fix in the
affected core package, describing the tab text truncation behavior and selecting
the appropriate release bump; do not treat this change as internal-only.
- Around line 118-122: Add regression coverage for the ellipsis behavior
introduced in the tab-item styling by extending the tabs component tests near
the existing stretched-class case. Render an oversized label, constrain the
relevant element, and assert that its rendered truncation behavior is applied
rather than only checking the stretched class; also add the required axe-based
accessibility assertion for the component test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8abede4c-95ac-49d4-8959-4473e76fc08a
📒 Files selected for processing (1)
packages/core/src/components/tab-item/tab-item.scss
|
EIX-68 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/curvy-swans-rescue.md:
- Around line 5-6: Update the changeset text to use “ellipsized” and “too long”
while preserving the existing description of the stretched tab-item layout fix.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4845ce5f-b9bb-4ce6-827c-49f1d0e3eafd
📒 Files selected for processing (1)
.changeset/curvy-swans-rescue.md
|
💡 What is the current behavior?
Setting layout=stretched for ix-tabs does not ellipse the text correctly if it has to little space.
GitHub Issue Number: EIX-68
🆕 What is the new behavior?
Text ellipses now correctly when space is not enough and property layout=stretched is set.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support
Summary by CodeRabbit
Bug Fixes