Skip to content

2667 - fix vue types path and add changeset (patch) - #2676

Merged
nuke-ellington merged 1 commit into
mainfrom
fix/2667_fix_vue_types_path
Jul 28, 2026
Merged

nuke-ellington merged 1 commit into
mainfrom
fix/2667_fix_vue_types_path

Conversation

@benjgil

@benjgil benjgil commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

💡 What is the current behavior?

ix-vue has an incorrect path in the "types" field in package.json, so typescript projects fail when using the package

GitHub Issue Number: #2667

🆕 What is the new behavior?

The path is now fixed, via fixing the rootDir property in tsconfig for the vue package

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

N/A

Summary by CodeRabbit

  • Bug Fixes

    • Corrected the published Vue package’s TypeScript declaration path, improving compatibility for TypeScript consumers.
  • Chores

    • Added a patch release entry for the fix.

@netlify

netlify Bot commented Jul 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for ix-storybook canceled.

Name Link
🔨 Latest commit 9edb450
🔍 Latest deploy log https://app.netlify.com/projects/ix-storybook/deploys/6a6852996933a30008b9fb57

@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9edb450

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-vue Patch
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 757bef56-2538-470c-8c2f-5bad79e831da

📥 Commits

Reviewing files that changed from the base of the PR and between 70e1c5c and 9edb450.

📒 Files selected for processing (2)
  • .changeset/vue-types-path-fix.md
  • packages/vue/tsconfig.json

📝 Walkthrough

Walkthrough

The Vue package TypeScript rootDir changes from the project root to src, producing declarations at dist/index.d.ts. A Changesets entry records a patch release for @siemens/ix-vue.

Changes

Vue package declaration output

Layer / File(s) Summary
Declaration output and release metadata
packages/vue/tsconfig.json, .changeset/vue-types-path-fix.md
TypeScript uses src as the root directory, and the Changesets entry documents the corrected declaration path with a patch version bump.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

  • siemens/ix#2667 — The change directly addresses the incorrect @siemens/ix-vue declaration path.

Suggested reviewers: danielleroux

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main fix and the accompanying patch changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/2667_fix_vue_types_path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@nuke-ellington nuke-ellington added this to the 5.2.0 milestone Jul 28, 2026
@nuke-ellington
nuke-ellington merged commit 60d38b5 into main Jul 28, 2026
48 of 52 checks passed
@nuke-ellington
nuke-ellington deleted the fix/2667_fix_vue_types_path branch July 28, 2026 10:23
@github-actions github-actions Bot mentioned this pull request Jul 28, 2026
SaiYugandhar03 pushed a commit to SaiYugandhar03/ix that referenced this pull request Jul 29, 2026
SaiYugandhar03 pushed a commit to SaiYugandhar03/ix that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants