Repository navigation
fix: (core/blind and core/push-card) Refactor: Align Border Coloring and Outline Variants with Design System #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
19a9d70
Added borders for blind and pushcard.
1307-Dev 13dbcda
FInalizing format
1307-Dev da681eb
used variables instead of hardcoded strings
1307-Dev 8a48cf2
Added change for outline variant
1307-Dev 5db08d3
correction for bottom height
1307-Dev ac64e98
Merge branch 'main' into ix-4047-blind-pushcard
1307-Dev 41d691b
added more rounded borders around the bottom corners
1307-Dev 960a39b
Changes added to scss
1307-Dev af710ef
added hide
1307-Dev 7ea4ac1
Fix
1307-Dev 158c2cf
reverted filled to use previous CSS
1307-Dev 78de17b
added changes for push card
1307-Dev 2b5d218
Updating snapshots
1307-Dev 5c94aab
Merge branch 'main' into ix-4047-blind-pushcard
1307-Dev f48bd9f
Merge branch 'main' into ix-4047-blind-pushcard
1307-Dev 53785b2
Create brave-jeans-rule.md
nuke-ellington e642b18
Create brave-jeans-rulez.md
nuke-ellington 0ed5a7b
Added changes from comments
1307-Dev 32777b0
Merge remote-tracking branch 'origin/main' into ix-4047-blind-pushcard
1307-Dev fe71689
Added fix for blind animation
1307-Dev 99a5605
Merge branch 'main' into ix-4047-blind-pushcard
1307-Dev c568ed9
Added some fixes
1307-Dev 228bc96
Addressing comments
1307-Dev c7a1e0b
Merge branch 'main' into ix-4047-blind-pushcard
1307-Dev 3d2de2e
Updated VRT snapshots
1307-Dev 2048337
Added 1px border fix when collapsed
1307-Dev 1033459
Addressing review comments regarding animation and border width
1307-Dev 4a24d70
Merge branch 'main' into ix-4047-blind-pushcard
1307-Dev b9f77d2
Added push card snapshots after changes
1307-Dev fa52d13
Dead code cleanup
1307-Dev 086996f
Merge branch 'main' into ix-4047-blind-pushcard
1307-Dev c0fa7e5
Merge branch 'main' into ix-4047-blind-pushcard
1307-Dev 964a809
Merge branch 'main' into ix-4047-blind-pushcard
nuke-ellington dd847e0
fix(core/card-accordion): update animation
nuke-ellington af3743d
fix(core/blind): outline variant height
nuke-ellington File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@siemens/ix": patch | ||
| --- | ||
|
|
||
| Color **ix-blind** borders according to variant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@siemens/ix": patch | ||
| --- | ||
|
|
||
| Color **ix-push-card** borders according to variant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+339 Bytes
(100%)
...hots__/tests/blind/blind.e2e.ts/blind-basic-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+443 Bytes
(100%)
...ots__/tests/blind/blind.e2e.ts/blind-basic-1-chromium---classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2 Bytes
(100%)
...__/tests/blind/blind.e2e.ts/blind-collapsed-1-chromium---classic-dark-linux.png
|
nuke-ellington marked this conversation as resolved.
Resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6 Bytes
(100%)
..._/tests/blind/blind.e2e.ts/blind-collapsed-1-chromium---classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+318 Bytes
(100%)
...ests/blind/blind.e2e.ts/blind-custom-header-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+380 Bytes
(100%)
...sts/blind/blind.e2e.ts/blind-custom-header-1-chromium---classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-337 Bytes
(100%)
...e.ts/push-card-basic-should-click-accordion-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(100%)
....ts/push-card-basic-should-click-accordion-1-chromium---classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.