Repository navigation
docs(chatbot): add component pages - #244
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces documentation and sidebar configuration for new AI chatbot components, including an overview, chat input, user message, and AI message. The reviewer provided feedback on several markdown files to align the component descriptions with the repository style guide, specifically recommending the use of plural component names, active voice, and referring to 'users' instead of 'the user'. All review comments are valid and should be addressed.
Expand the chat-input documentation with a full usage guide (anatomy, options, behavior/overflow, states, dos & don'ts, and related links). Also add three Figma illustration PNGs to static/figma to support the new documentation.
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughChangesChat documentation
Pull-request environment
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* new guide for ai message * new guide for chat * new guide for user message * renamed folder and chat (removed AI)
flxlst09
left a comment
There was a problem hiding this comment.
Like it, very concise!
- Chat attachment still open
- Entries in component overview missing
- How to link to Conversational guidelines (UX Writing)
- How to mention that a SDL AI Figma file exists for Siemens users
And some smaller stuff :)
Add a new Chat attachment usage guide (anatomy, options, behavior, states, dos/don’ts) and include a related Figma image. Refine copy across chat-related docs: AI message, Chat input, and User message (clarify wording and responsiveness). Update sidebars labels for chat and chat-attachment, and update/add several Figma static images.
removed the deeplink to the icon until we know how to do them
flxlst09
left a comment
There was a problem hiding this comment.
Reviewed the md, preview deployment did not work. Only smaller stuff, good to go once addressed
tokyojen
left a comment
There was a problem hiding this comment.
Added quite a lot of comments to try to make sure it matches with Sidhu and our content. Might need to check a few things together.
tokyojen
left a comment
There was a problem hiding this comment.
Added quite a lot of comments to try to make sure it matches with Sidhu and our content. Might need to check a few things together.
Co-authored-by: Kathrin <123640803+kathrinschalber@users.noreply.github.com>
flxlst09
left a comment
There was a problem hiding this comment.
Some polishing suggestions and one thing we should check: linked Figma files should be accessible for Siemens Figma users without requesting access.
- Fix indentation of nested list items in chat, chat-input, and chat-attachment guides - Clarify tooltip behavior for truncated attachment filenames - Update chat-input states count from six to four - Add responsiveness info (max-width: 45rem) to chat component - Minor wording improvements and link restructuring - Update chat-input states screenshot
tokyojen
left a comment
There was a problem hiding this comment.
Great - many thanks for the alignment! Good to go! No more comments or changes.
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/components/chat-attachment/code.mdx`:
- Around line 6-7: Update the ChatAttachmentPlayground import in the chat
attachment documentation to reference the chat-attachment playground MDX module
instead of chat-user-message.mdx. Leave the PropsApi import unchanged.
In `@docs/components/chat-input/guide.md`:
- Line 27: Update the disclaimer link in the documented AI disclaimer text to
use descriptive link text that identifies the Siemens AG legal disclaimers,
rather than the generic “here,” while preserving the existing destination URL
and surrounding guidance.
In `@docs/components/overview.md`:
- Line 186: Update the AI message description in the overview table to correct
the grammar, replacing “in a conversational chats” with either “in a
conversational chat” or “in conversational chats.”
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 40a4291e-fa47-4e7f-a04d-3319e5ade544
⛔ Files ignored due to path filters (8)
static/figma/wEptRgAezDU1z80Cn3eZ0o_7940_2809.pngis excluded by!**/*.pngstatic/figma/wEptRgAezDU1z80Cn3eZ0o_7940_7020.pngis excluded by!**/*.pngstatic/figma/wEptRgAezDU1z80Cn3eZ0o_7940_7427.pngis excluded by!**/*.pngstatic/figma/wEptRgAezDU1z80Cn3eZ0o_7959_1370.pngis excluded by!**/*.pngstatic/figma/wEptRgAezDU1z80Cn3eZ0o_7959_520.pngis excluded by!**/*.pngstatic/figma/wEptRgAezDU1z80Cn3eZ0o_7962_804.pngis excluded by!**/*.pngstatic/figma/wEptRgAezDU1z80Cn3eZ0o_7970_230.pngis excluded by!**/*.pngstatic/figma/wEptRgAezDU1z80Cn3eZ0o_7974_3280.pngis excluded by!**/*.png
📒 Files selected for processing (18)
.env.pullrequestdocs/components/ai-message/code.mdxdocs/components/ai-message/guide.mddocs/components/ai-message/index.mdxdocs/components/chat-attachment/code.mdxdocs/components/chat-attachment/guide.mddocs/components/chat-attachment/index.mdxdocs/components/chat-input/code.mdxdocs/components/chat-input/guide.mddocs/components/chat-input/index.mdxdocs/components/chat/code.mdxdocs/components/chat/guide.mddocs/components/chat/index.mdxdocs/components/overview.mddocs/components/user-message/code.mdxdocs/components/user-message/guide.mddocs/components/user-message/index.mdxsidebars.ts
| import ChatAttachmentPlayground from '@site/docs/autogenerated/playground/chat-user-message.mdx'; | ||
| import PropsApi from '@site/docs/autogenerated/api/ix-chat-attachment/api.mdx'; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Correct the playground import for chat attachment.
It looks like chat-user-message.mdx was accidentally imported here instead of the chat attachment playground due to a copy-paste error.
🐛 Proposed fix
-import ChatAttachmentPlayground from '`@site/docs/autogenerated/playground/chat-user-message.mdx`';
+import ChatAttachmentPlayground from '`@site/docs/autogenerated/playground/chat-attachment.mdx`';
import PropsApi from '`@site/docs/autogenerated/api/ix-chat-attachment/api.mdx`';📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import ChatAttachmentPlayground from '@site/docs/autogenerated/playground/chat-user-message.mdx'; | |
| import PropsApi from '@site/docs/autogenerated/api/ix-chat-attachment/api.mdx'; | |
| import ChatAttachmentPlayground from '`@site/docs/autogenerated/playground/chat-attachment.mdx`'; | |
| import PropsApi from '`@site/docs/autogenerated/api/ix-chat-attachment/api.mdx`'; |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/components/chat-attachment/code.mdx` around lines 6 - 7, Update the
ChatAttachmentPlayground import in the chat attachment documentation to
reference the chat-attachment playground MDX module instead of
chat-user-message.mdx. Leave the PropsApi import unchanged.
| - **Attachment slot:** Optionally include a slot for [attachments](../chat-attachment/). | ||
| - **Start slot:** Add secondary actions. We recommend using tertiary outline [icon buttons](../icon-button) and trying to stick to one action. If you have more than one action, use [dropdown buttons](../dropdown-button/). | ||
| - **End slot:** Use this slot to add alternative input methods, e.g. voice input. | ||
| - **Disclaimer:** In AI contexts, we recommend including a visible disclaimer under the input instead of under each [AI message](../ai-message/). For Siemens AG products, find legal disclaimers [here](https://code.siemens.com/siemens-ix/ix-brand-theme/-/blob/main/apps/documentation/src/pages/legal-disclaimers-copilots.md). |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use descriptive link text.
Using "here" as the link text is bad for accessibility and readability. It's better to use descriptive text for the link.
💡 Proposed fix
-- **Disclaimer:** In AI contexts, we recommend including a visible disclaimer under the input instead of under each [AI message](../ai-message/). For Siemens AG products, find legal disclaimers [here](https://code.siemens.com/siemens-ix/ix-brand-theme/-/blob/main/apps/documentation/src/pages/legal-disclaimers-copilots.md).
+- **Disclaimer:** In AI contexts, we recommend including a visible disclaimer under the input instead of under each [AI message](../ai-message/). For Siemens AG products, refer to the [legal disclaimers](https://code.siemens.com/siemens-ix/ix-brand-theme/-/blob/main/apps/documentation/src/pages/legal-disclaimers-copilots.md).📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - **Disclaimer:** In AI contexts, we recommend including a visible disclaimer under the input instead of under each [AI message](../ai-message/). For Siemens AG products, find legal disclaimers [here](https://code.siemens.com/siemens-ix/ix-brand-theme/-/blob/main/apps/documentation/src/pages/legal-disclaimers-copilots.md). | |
| - **Disclaimer:** In AI contexts, we recommend including a visible disclaimer under the input instead of under each [AI message](../ai-message/). For Siemens AG products, refer to the [legal disclaimers](https://code.siemens.com/siemens-ix/ix-brand-theme/-/blob/main/apps/documentation/src/pages/legal-disclaimers-copilots.md). |
🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 27-27: Link text should be descriptive
(MD059, descriptive-link-text)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/components/chat-input/guide.md` at line 27, Update the disclaimer link
in the documented AI disclaimer text to use descriptive link text that
identifies the Siemens AG legal disclaimers, rather than the generic “here,”
while preserving the existing destination URL and surrounding guidance.
Source: Linters/SAST tools
| | [Chat](./chat/index.mdx) | Chat component for building conversational chatbot experiences. | | ||
| | [Chat input](./chat-input/index.mdx) | Chat inputs are used to compose and submit messages, attachments and follow-up actions in a conversational AI thread. | | ||
| | [User message](./user-message/index.mdx) | User messages display messages authored by the user in a chat thread. | | ||
| | [AI message](./ai-message/index.mdx) | AI messages display responses generated by the AI in a conversational chats. | |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix typographical error in the description.
The phrase "in a conversational chats" is grammatically incorrect. Please update it to "in a conversational chat" or "in conversational chats" for better clarity.
📝 Proposed fix
-| [AI message](./ai-message/index.mdx) | AI messages display responses generated by the AI in a conversational chats. |
+| [AI message](./ai-message/index.mdx) | AI messages display responses generated by the AI in a conversational chat. |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | [AI message](./ai-message/index.mdx) | AI messages display responses generated by the AI in a conversational chats. | | |
| | [AI message](./ai-message/index.mdx) | AI messages display responses generated by the AI in a conversational chat. | |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/components/overview.md` at line 186, Update the AI message description
in the overview table to correct the grammar, replacing “in a conversational
chats” with either “in a conversational chat” or “in conversational chats.”
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
💡 What is the current behavior?
Jira: IX-4307 and IX-4410
🆕 What is the new behavior?
Implementation is here: siemens/ix#2569
👨💻 Help & support
Summary by CodeRabbit