Repository navigation
test(server): strip fork home aliases from the test environment - #350
Merged
Merged
Conversation
The server test setup removed T3CODE_HOME but left S2CODE_HOME and SHUV2CODE_HOME, which the fork resolves back into T3CODE_HOME, so tests could still reach the live nightly userdata on a developer machine. Delete both aliases alongside T3CODE_HOME in the shared setup file. Claude Fable 5.1 via Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The apps/server test setup deleted
T3CODE_HOMEbut leftS2CODE_HOMEandSHUV2CODE_HOME. The fork resolves those aliases back intoT3CODE_HOME, so on a developer machine with the nightly home exported, tests could still reach the live nightly userdata.The shared setup file now deletes both aliases alongside
T3CODE_HOME.Verification (same machine,
S2CODE_HOME,SHUV2CODE_HOMEandT3CODE_HOMEall exported to the nightly home):apps/serversuite before: 13 files / 27 tests failed, 5586 passed (the known base failures).apps/serversuite after: the same 27 failures remain; none cleared, none newly introduced. One extrahttp.test.tsfailure in the after run passed when rerun alone (load flake).vpr knip:check: pass. Filtered typecheck (server, contracts, shared, web): 4/4 pass.The remaining base failures are unrelated to the home environment (stale
shuv2codenaming expectations, macOS/private/varpath realpaths, desktop app reachability, timeouts).Claude Fable 5.1 via Claude Code