Merged
Conversation
jfboismenu
approved these changes
Aug 26, 2019
Contributor
jfboismenu
left a comment
jfboismenu
left a comment
There was a problem hiding this comment.
LGTM
Could you take this opportunity to skip the tests that are false failures in CI so we get back to a green state? Thanks.
and Python 2.6 support on AppVeyor is limited.
willis102
force-pushed
the
SG-13608-revert-mimetypes
branch
from
cdf50a9 to
93962ba
Compare
willis102
force-pushed
the
SG-13608-revert-mimetypes
branch
from
e7c926f to
6b3e63a
Compare
willis102
force-pushed
the
SG-13608-revert-mimetypes
branch
from
6b3e63a to
79cff31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the python3 compatibility pass, the bundled mimetypes module was made python3 compatible. This was not necessary as this module is only used in certain versions of python2. Revert the compatibility changes and add a comment explaining why the module is not python3 compatible.