Skip to content

add support for GNOME console and newer GNOME editors #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiftkey merged 6 commits into from
Apr 21, 2022
Merged

add support for GNOME console and newer GNOME editors #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f096d9
add support for gnome console
Etaash-mathamsetty Apr 18, 2022
8e0d515
Delete configurationCache.log
Etaash-mathamsetty Apr 18, 2022
acd142a
Update linux.ts
Etaash-mathamsetty Apr 18, 2022
83880be
fix cap of gnome
Etaash-mathamsetty Apr 18, 2022
4d4755a
support new GNOME Text Editor
Etaash-mathamsetty Apr 18, 2022
5f38d24
support GNOME builder
Etaash-mathamsetty Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/src/lib/editors/linux.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,17 @@ const editors: ILinuxExternalEditor[] = [
paths: ['/usr/bin/kate'],
},
{
name: 'GNOME Text Editor',
name: 'GEdit',
paths: ['/usr/bin/gedit'],
},
{
name: 'GNOME Text Editor',
paths: ['/usr/bin/gnome-text-editor'],
},
{
name: 'GNOME Builder',
paths: ['/usr/bin/gnome-builder'],
},
{
name: 'Notepadqq',
paths: ['/usr/bin/notepadqq'],
Expand Down
10 changes: 10 additions & 0 deletions app/src/lib/shells/linux.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { pathExists as pathExistsLinux, spawnShell } from '../helpers/linux'

export enum Shell {
Gnome = 'GNOME Terminal',
GnomeConsole = 'GNOME Console',
Mate = 'MATE Terminal',
Tilix = 'Tilix',
Terminator = 'Terminator',
Expand Down Expand Up @@ -34,6 +35,8 @@ function getShellPath(shell: Shell): Promise<string | null> {
switch (shell) {
case Shell.Gnome:
return getPathIfAvailable('/usr/bin/gnome-terminal')
case Shell.GnomeConsole:
return getPathIfAvailable('/usr/bin/kgx')
case Shell.Mate:
return getPathIfAvailable('/usr/bin/mate-terminal')
case Shell.Tilix:
Expand Down Expand Up @@ -68,6 +71,7 @@ export async function getAvailableShells(): Promise<
> {
const [
gnomeTerminalPath,
gnomeConsolePath,
mateTerminalPath,
tilixPath,
terminatorPath,
Expand All @@ -82,6 +86,7 @@ export async function getAvailableShells(): Promise<
kittyPath,
] = await Promise.all([
getShellPath(Shell.Gnome),
getShellPath(Shell.GnomeConsole),
getShellPath(Shell.Mate),
getShellPath(Shell.Tilix),
getShellPath(Shell.Terminator),
Expand All @@ -101,6 +106,10 @@ export async function getAvailableShells(): Promise<
shells.push({ shell: Shell.Gnome, path: gnomeTerminalPath })
}

if (gnomeConsolePath) {
shells.push({ shell: Shell.GnomeConsole, path: gnomeConsolePath })
}

if (mateTerminalPath) {
shells.push({ shell: Shell.Mate, path: mateTerminalPath })
}
Expand Down Expand Up @@ -159,6 +168,7 @@ export function launch(
const shell = foundShell.shell
switch (shell) {
case Shell.Gnome:
case Shell.GnomeConsole:
case Shell.Mate:
case Shell.Tilix:
case Shell.Terminator:
Expand Down