Skip to content

enable supportsSystemThemeChanges() for all Linux builds - #663

Merged
shiftkey merged 1 commit into
linuxfrom
enable-theme-detection
Feb 23, 2022
Merged

enable supportsSystemThemeChanges() for all Linux builds#663
shiftkey merged 1 commit into
linuxfrom
enable-theme-detection

Conversation

@shiftkey

@shiftkey shiftkey commented Feb 22, 2022

Copy link
Copy Markdown
Owner

Resolves #372
Resolves #512

Description

Enabling the supportsSystemThemeChanges() change on Linux seems to handle the two cases that were reported earlier:

  • inherit from the system theme if set
  • changing the theme should not require a restart

Screenshots

With "System" chosen and dark theme selected

With "System" chosen and light theme selected

Release notes

Notes: enable system theme and synchronising with current OS light/dark theme

@shiftkey
shiftkey merged commit 83ae586 into linux Feb 23, 2022
@shiftkey
shiftkey deleted the enable-theme-detection branch February 23, 2022 12:57
shiftkey added a commit that referenced this pull request Apr 3, 2022
shiftkey added a commit that referenced this pull request Apr 3, 2022
shiftkey added a commit that referenced this pull request Apr 3, 2022
shiftkey added a commit that referenced this pull request Apr 3, 2022
shiftkey added a commit that referenced this pull request Apr 3, 2022
shiftkey added a commit that referenced this pull request Apr 3, 2022
shiftkey added a commit that referenced this pull request Apr 3, 2022
shiftkey added a commit that referenced this pull request Apr 8, 2022
shiftkey added a commit that referenced this pull request Aug 2, 2022
shiftkey added a commit that referenced this pull request Aug 2, 2022
shiftkey added a commit that referenced this pull request Sep 6, 2022
shiftkey added a commit that referenced this pull request Sep 6, 2022
shiftkey added a commit that referenced this pull request Sep 6, 2022
shiftkey added a commit that referenced this pull request Sep 6, 2022
shiftkey added a commit that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

changing theme needs restart Use system theme via matchMedia for auto dark mode option

1 participant