Skip to content

rewrite path change patch to work with new API #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiftkey merged 1 commit into from
Nov 4, 2024
Merged

rewrite path change patch to work with new API #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions app/src/ui/add-repository/add-existing-repository.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { showOpenDialog } from '../main-process-proxy'
import { Ref } from '../lib/ref'
import { InputError } from '../lib/input-description/input-error'
import { IAccessibleMessage } from '../../models/accessible-message'
import { isGitRepository } from './create-repository'

interface IAddExistingRepositoryProps {
readonly dispatcher: Dispatcher
Expand Down Expand Up @@ -254,9 +253,21 @@ export class AddExistingRepository extends React.Component<
}

private onPathChanged = async (path: string) => {
const isRepository = await isGitRepository(this.resolvedPath(path))
const type = await getRepositoryType(this.resolvedPath(path))

this.setState({ path, isRepository })
const isRepository = type.kind !== 'missing' && type.kind !== 'unsafe'
const isRepositoryUnsafe = type.kind === 'unsafe'
const isRepositoryBare = type.kind === 'bare'
const showNonGitRepositoryWarning = !isRepository || isRepositoryBare
const repositoryUnsafePath = type.kind === 'unsafe' ? type.path : undefined

this.setState({
path,
isRepositoryUnsafe,
isRepositoryBare,
showNonGitRepositoryWarning,
repositoryUnsafePath,
})
}

private showFilePicker = async () => {
Expand Down