Repository navigation
Conversation
jiapingW
requested review from
FlamingoPg,
FrankLeeeee,
shuaills and
sleepcoo
as code owners
November 1, 2026 03:09
This was referenced Nov 1, 2026
jiapingW
force-pushed
the
split/config-layer-contracts
branch
from
November 1, 2026 06:11
436969a to
a854575
Compare
jiapingW
force-pushed
the
split/config-component-extraction
branch
from
November 1, 2026 06:11
8258522 to
61f1199
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add immutable AttentionSpec/FFNSpec/ResidualSpec/ConvSpec grouped into LayerSpec, a decoder and an open registry of specs/builders. Keep these definitions together under config/draft/layers/ as specs.py, decoder.py and registry.py. Expand shared settings into a per-layer tuple and validate execution contracts and unknown fields.
Existing model call sites stay unchanged here; the next PR adopts these interfaces.
Depends on #1060.
Validation: 643 CPU-suite tests completed, 48 skipped.
Stack: #1042 → #1043 → #1058 → #1059 → #1044 → #1060 → #1061 → #1052 → #1045 → #1046.
Independent CPU CI: #1053.