test: fix e2e tests - #197
Merged
Merged
Conversation
devbv
approved these changes
Aug 13, 2024
jacobhjkim
added a commit
that referenced
this pull request
Aug 13, 2024
This reverts commit d732eeb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fix e2e tests
We need to use a specific version of
stretchr/testifyto include this PR (stretchr/testify#1481). Without it,EventuallyWithTdoes not work well withrequire.EventuallyWithTis preferable to plainEventuallybecause it shows exactly which condition is not met. For example,Eventually's error looks like this:In contrast,
EventuallyWithT's error log is more informative:e2e_settlement_test.go:199: Error Trace: /Users/jacob/work/chain/tests/e2e/e2e_settlement_test.go:199 /opt/homebrew/Cellar/go/1.22.5/libexec/src/runtime/asm_arm64.s:1222 Error: Not equal: expected: 3 actual : 2 Test: TestIntegrationTestSuite/TestMintableContractTenant/create_new_tenant