fix: add Serde std feature if needed - #1068
Merged
Merged
Conversation
valenting
requested changes
Aug 22, 2025
valenting
left a comment
Collaborator
There was a problem hiding this comment.
Could you also bump the version to 2.5.7 - also in lib.rs?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
=======================================
Coverage ? 82.63%
=======================================
Files ? 24
Lines ? 4245
Branches ? 0
=======================================
Hits ? 3508
Misses ? 737
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
I've changed it in url/Cargo.toml, and url/lib.rs |
valenting
approved these changes
Aug 23, 2025
valenting
enabled auto-merge
August 23, 2025 12:23
takumi-earth
pushed a commit
to earthlings-dev/rust-url
that referenced
this pull request
Jan 27, 2026
* fix: add Serde std feature if needed * bump the version to 2.5.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue introduced by #1033
Serde no longer include std feature that result in an error when using url with serde feature:
This PR solve this by adding the
stdflag if needed to serde.I've test it for my project, it work.