Skip to content

feat: allow nginx client_max_body_size to be configurable#558

Merged
jaydrogers merged 4 commits into
serversideup:280-create-a-frankenphp-variationfrom
dlundgren:dl/nginx-client_max_body_size
Oct 1, 2025
Merged

feat: allow nginx client_max_body_size to be configurable#558
jaydrogers merged 4 commits into
serversideup:280-create-a-frankenphp-variationfrom
dlundgren:dl/nginx-client_max_body_size

Conversation

@dlundgren
Copy link
Copy Markdown
Contributor

  • Adds a new NGINX_CLIENT_MAX_BODY_SIZE option
  • Moves the client_max_body_size from the server templates to the nginx.conf template.

@jaydrogers jaydrogers changed the base branch from main to release/v3.6 August 22, 2025 17:38
@jaydrogers jaydrogers deleted the branch serversideup:280-create-a-frankenphp-variation August 28, 2025 21:29
@jaydrogers jaydrogers closed this Aug 28, 2025
@jaydrogers
Copy link
Copy Markdown
Member

Sorry for the hiccup here, but could you try creating a new PR?

I had to move things in GitHub it automatically closed this PR. I don't see where I can update the branch into https://github.com/serversideup/docker-php/tree/280-create-a-frankenphp-variation

It won't let me change it when I press edit.

@jaydrogers jaydrogers reopened this Aug 28, 2025
@jaydrogers jaydrogers changed the base branch from release/v3.6 to 280-create-a-frankenphp-variation August 28, 2025 21:37
@jaydrogers
Copy link
Copy Markdown
Member

NVM, I got it. I accidentally deleted the source branch. That's why it closed. I will be reviewing this for 4.0 and will keep you posted 👍

Sorry for the confusion!

@jaydrogers
Copy link
Copy Markdown
Member

This looks great, thank you for your help!

Quick change I made

  • Default is 2G100M

I set it to 100M to match what we have for PHP_MAX_UPLOAD_SIZE. I even considered just having PHP_MAX_UPLOAD_SIZE in the NGINX configuraiton, but I figured there would be that ONE person who would need to have it separated 🤪

Why 100M?

This is the default value for the CloudFlare free plan. Also, setting 2G (from what we had before) might have been an old config that I had from years ago. We don't want that number too high so people can blow up a server through a DDoS attack 🤓

Thanks for your contribution!

@jaydrogers jaydrogers merged commit 4bb3173 into serversideup:280-create-a-frankenphp-variation Oct 1, 2025
@github-project-automation github-project-automation Bot moved this from 🤔 Evaluating to Done in serversideup/php v4.0 Oct 1, 2025
@jaydrogers
Copy link
Copy Markdown
Member

Also, cool to see the contribution come from a fellow Milwaukee developer! 🍻🧀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants