Added pm.max_requests to pool#486
Conversation
pm.max_requests added
added PHP_FPM_PM_MAX_REQUESTS
angristan
left a comment
There was a problem hiding this comment.
Thanks! I was searching for this option as well.
Let's keep in mind the default seems to be 0 (https://www.php.net/manual/en/install.fpm.configuration.php):
pm.max_requests (int)
The number of requests each child process should execute before respawning. This can be useful to work around memory leaks in 3rd party libraries. For endless request processing specify '0'. Equivalent to PHP_FCGI_MAX_REQUESTS. Default value: 0.
So we might want to keep that.
|
Also
|
|
Very cool! Looking for exactly that feature. In my opinion, however, the default should also be 0, as this is also in the FPM default. And some documentation should be added, it's missing in the PR. I did this here: #513 |
|
Thanks for raising this feature @ifaridjalilov. Since #513 has the documentation and the proper defaults, I am going to use that PR. Thanks for publishing this though. We will always appreciate any future contributions 👍 |
You can set with PHP_FPM_PM_MAX_REQUESTS.
Default 1000