Fix: case migration failed#478
Closed
aagjalpankaj wants to merge 4 commits into
Closed
Conversation
angristan
approved these changes
Jan 2, 2025
Member
|
I greatly appreciate your efforts to open an issue an propose a solution on this! In #511, I worked with another developer to completely refactor and improve the Laravel Automations script. While I was working on that branch, I changed some entrypoint execution strategies that allow the Laravel Automations script to fail:
You can see in the image I wrote a bad migration from an image built on #511 and the container exits at the bottom because of the failure (which is our expected result). Although we won't be merging your proposed solution on this issue, we definitely welcome any future contributions. Thanks for helping the community out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Steps To Reproduce
In such case, code changes will be deployed, but schema changes will not, which may break the application state.
Outcome
What did you expect?
Deployment should be rollbacked or should not succeed when migration fails
What happened instead?
Code changes deployed / Deployment succeeded
Affected Docker Images
I guess most of the images if people are using it for Laravel application with
AUTORUN_ENABLED="true"option.This PR fixes #477