Introduce System.Nullable fast path - #369
Merged
Merged
Conversation
Right now deserializing System.Nullable has to go through multiple interface dispatch hops to finally get to the underlying type. This change allows for simplifying most of the dispatch logic -- the worst case only adds a pair. The new pattern is that IDeserializer should provide a 'TryReadNull' fast path that proxies can use to quickly check for null, then bail out if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now deserializing System.Nullable has to go through multiple interface dispatch hops to finally get to the underlying type. This change allows for simplifying most of the dispatch logic -- the worst case only adds a ReadFieldStart/ReadFieldEnd pair.
The new pattern is that IDeserializer should provide a 'TryReadNull' fast path that proxies can use to quickly check for null, then bail out if needed.