Skip to content

Fix number of points to draw#289

Merged
at-wat merged 1 commit intomasterfrom
fix-number-of-points-to-draw
May 2, 2025
Merged

Fix number of points to draw#289
at-wat merged 1 commit intomasterfrom
fix-number-of-points-to-draw

Conversation

@at-wat
Copy link
Copy Markdown
Member

@at-wat at-wat commented Apr 25, 2025

I don't remember why there were -1

This caused wrong points deletion/labeling result when the number of the points are larger than maxDrawArraysPoints

@at-wat at-wat self-assigned this Apr 25, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.16%. Comparing base (21954bf) to head (3911faa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   38.16%   38.16%           
=======================================
  Files           8        8           
  Lines        1643     1643           
=======================================
  Hits          627      627           
  Misses        980      980           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@at-wat at-wat closed this Apr 28, 2025
@at-wat at-wat reopened this Apr 28, 2025
@at-wat at-wat requested a review from f-fl0 May 2, 2025 02:36
Copy link
Copy Markdown
Contributor

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit 65e6103 into master May 2, 2025
8 checks passed
@at-wat at-wat deleted the fix-number-of-points-to-draw branch May 2, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants