Added support for calloc as allocator function for heap security rules.#3795
Open
dannytheway wants to merge 2 commits intosemgrep:developfrom
Open
Added support for calloc as allocator function for heap security rules.#3795dannytheway wants to merge 2 commits intosemgrep:developfrom
dannytheway wants to merge 2 commits intosemgrep:developfrom
Conversation
Fix: Better detection of direct access to pointed memory.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: use-after-free rule for the C language gives a false positive when
calloc()is used as onlymalloc()is supported.All rules for heap based vulnerabilities for the C language now support the
calloc()instead of justmalloc().Additionally other allocator functions can be easily added to the list.
Additional Fix: Rule use-after-free didn't consider accessing memory as
*var = ...vulnerable.So a pattern to detect direct access to pointed memory was added.