Skip to content

t_hid and t_codec_video follow the PRAGMATA port (they no longer link or compile on main) - #2396

Open
lunks wants to merge 1 commit into
seedds:mainfrom
lunks:pr/test-gaps
Open

lunks wants to merge 1 commit into
seedds:mainfrom
lunks:pr/test-gaps

Conversation

@lunks

@lunks lunks commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

What and why

ccd834e0 (PRAGMATA port) changed two things the host tests call, and left the tests as they were, so make -C dm/host/tests GAME=<id> run stops on main:

  • hle_hid.c gained the DM_CTL commands atrace, addr and bufsnap, which call probe_atrace, dm_gfx_addr_note and dm_gfx_bufsnap. t_hid links hle_hid.c without the graphics host, so it fails with three undefined symbols. The three get stubs next to the other dm_gfx_* ones.
  • The h_cv_*init2 overloads of hle_codec_video.c take the stream's parameter sets (const void *csd, uint64_t csd_n) after out. The four calls in t_codec_video still passed seven arguments ("too few arguments, expected 9, have 7"). They now pass NULL, 0, as for a stream with no parameter sets.

Tests only: no host code changes.

Checked

  • Tests: on main, make -C dm/host/tests GAME=0400486024DEC000 build/t_hid fails with the three undefined symbols and build/t_codec_video with the argument error; with the change t_hid prints "251 checks, 0 failed" and t_codec_video "all passed". The rest of the host suite ran on a tree with the same two fixes: everything passes (audio-device aborted once in a background-priority run and passes alone).
  • Games run: none (tests only).
  • Devices and OS: M5 Pro, macOS 27.0.
  • Not checked: iOS; the libvpx and dav1d libraries came from another worktree's gen/ (same sources).

Docs

  • No reference entry needed (test fixes); the host and shader chain are unchanged
  • No game files, keys or data extracted from a game in the change or the attachments

…ontrol commands, the parameter-set arguments of the Initialize overloads
@github-actions github-actions Bot added the host The Horizon host: SVCs, services, threads, memory (dm/host) label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

host The Horizon host: SVCs, services, threads, memory (dm/host)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant