Repository navigation
Conversation
…ontrol commands, the parameter-set arguments of the Initialize overloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
ccd834e0(PRAGMATA port) changed two things the host tests call, and left the tests as they were, somake -C dm/host/tests GAME=<id> runstops on main:hle_hid.cgained the DM_CTL commandsatrace,addrandbufsnap, which callprobe_atrace,dm_gfx_addr_noteanddm_gfx_bufsnap.t_hidlinkshle_hid.cwithout the graphics host, so it fails with three undefined symbols. The three get stubs next to the otherdm_gfx_*ones.h_cv_*init2overloads ofhle_codec_video.ctake the stream's parameter sets (const void *csd, uint64_t csd_n) afterout. The four calls int_codec_videostill passed seven arguments ("too few arguments, expected 9, have 7"). They now passNULL, 0, as for a stream with no parameter sets.Tests only: no host code changes.
Checked
make -C dm/host/tests GAME=0400486024DEC000 build/t_hidfails with the three undefined symbols andbuild/t_codec_videowith the argument error; with the changet_hidprints "251 checks, 0 failed" andt_codec_video"all passed". The rest of the host suite ran on a tree with the same two fixes: everything passes (audio-deviceaborted once in a background-priority run and passes alone).gen/(same sources).Docs