Conversation
maretskiy
suggested changes
Dec 27, 2016
Contributor
maretskiy
left a comment
There was a problem hiding this comment.
LGTM, however there is one important comment
| port=app.config.get("PORT", 5000)) | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
Contributor
Author
There was a problem hiding this comment.
Why? It is not used it is not used anyway.
Contributor
There was a problem hiding this comment.
I've tried `python availability/main.py' - this does not cause CLI to run.
Maybe there is another way to get flask started?
Contributor
Author
There was a problem hiding this comment.
Sure, you should start availability-api after installing the availability package because it provides two console scripts: availability-api and availability-watcher.
You can create your own virtualenv and install availability into it:
git clone https://github.com/seecloud/availability.git
cd availability
virtualenv .venv
.venv/bin/pip install .
And then run it:
.venv/bin/availability-api --help
So, we can create a special target in tox.ini to simplify this preparation of venv and it will look like:
tox -e venv -- availability-api --help
maretskiy
approved these changes
Dec 28, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.